Changeset - 245d051b38b3
[Not reviewed]
0 1 0
Andrew Browning - 10 months ago 2018-07-08 15:29:05
ayleph@thisshitistemp.com
Prevent video plugin from processing svg [#934]

Prior to the gstreamer-1.0 upgrade, the video processing engine included
a check for excluded extensions which gstreamer might accept despite us
not wanting to process them. In commit 91f5f5e, the check against
EXCLUDED_EXT was removed. Since then, the video plugin has accepted and
attempted to process svg files.

This commit adds the check against EXCLUDED_EXTS into the sniff_handler
function so that we can bail out on certain file extensions before the
plugins tries to sniff the file type. The previous implementation
excluded nef files, which appears to be a Nikon camera image. I've
copied that forward to this code. I've also added a log message to
indicate that we're purposefully refusing to process the file.
1 file changed with 10 insertions and 0 deletions:
0 comments (0 inline, 0 general)
mediagoblin/media_types/video/processing.py
Show inline comments
...
 
@@ -79,7 +79,17 @@ def sniffer(media_file):
 
    return MEDIA_TYPE
 

	
 

	
 
EXCLUDED_EXTS = ["nef", "svg"]
 

	
 
def sniff_handler(media_file, filename):
 
    name, ext = os.path.splitext(filename)
 
    clean_ext = ext.lower()[1:]
 

	
 
    if clean_ext in EXCLUDED_EXTS:
 
        # We don't handle this filetype, though gstreamer might think we can
 
        _log.info('Refused to process {0} due to excluded extension'.format(filename))
 
        return None
 

	
 
    try:
 
        return sniffer(media_file)
 
    except:
0 comments (0 inline, 0 general)